Update Kotlin & dependencies #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinSchildhorn
commented
Oct 9, 2024
KevinSchildhorn
commented
Oct 9, 2024
gradle/libs.versions.toml
Outdated
| @@ -6,21 +6,21 @@ compileSdk = "34" | |||
|
|
|||
| # Dependencies | |||
| kotlin = "2.0.10" | |||
| android-gradle-plugin = "8.2.2" | |||
| android-gradle-plugin = "8.7.0" | |||
There was a problem hiding this comment.
I thought I read something about not being able to use the latest gradle plugin because of KMP but I can't find it anymore, and it seems to run fine.
There was a problem hiding this comment.
There was a problem hiding this comment.
Added a comment
findjigar
reviewed
Oct 11, 2024
| coroutines = "1.8.1" | ||
| kotlinx-datetime = "0.6.0" | ||
| ktor = "2.3.11" | ||
| ktor = "2.3.12" |
There was a problem hiding this comment.
fyi, ktor 3.0.0 just released yesterday
There was a problem hiding this comment.
I wouldn't recommend upgrading to a major release before we publish Droidcon London. Who knows how many bugs there will be in the new version.
There was a problem hiding this comment.
Wasn't aware that we're publishing for Droidcon London. Makes sense
There was a problem hiding this comment.
Added a comment
findjigar
approved these changes
Oct 11, 2024
TadeasKriz
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating Dependencies
Running KtLint